Closed maxim-belkin closed 3 years ago
Thanks for the feedback, @jhlegarreta. I'm going to merge this PR because the tests have passed and there should be no issues with it as it merely adds a new image class. We can change the class name down the road if there are objections or concerns with the name I propose in this PR (inline
).
By the way, it seems that the img-responsive
class that you guys add to image definitions in carpentries-incubator/SDC-BIDS-dMRI lesson is not necessary because it adds
display: block;
max-width: 100%;
height: auto;
which intersects well with what we set for all images in lesson.scss
:
article img {
display: block;
margin: 20px auto;
max-width: 100%;
}
Note that height: auto
is not necessary because max-width
property automatically changes height (so, I'm not entirely sure why bootstrap guys do that, tbh).
Thanks for the hard work @maxim-belkin.
By the way, it seems that the img-responsive class that you guys add to image definitions in carpentries-incubator/SDC-BIDS-dMRI lesson is not necessary because it adds
Thanks for the note. I did not really dig into it, but it seems reasonable to remove our img-responsive
classes.
Define
inline
class for images that should not be displayed as block elements.By appending
{:class="inline"}
or{: .inline}
to an image definition in Markdown, one can create an inline image that doesn't break the current line and is embedded in the paragraph. Useful for showing special symbols and hieroglyphs that we can't display by other means.Example: Lesson: https://github.com/carpentries-incubator/SDC-BIDS-dMRI Episode: diffusion_tensor_imaging Diff:
Result:
CC @jhlegarreta