search

carpentries / tnd-carpentries-working

The Carpentries new website BEFORE the Hugo theme was packaged out. Not currently maintained.
https://tnd-carpentries-website.netlify.app/
0 stars 0 forks source link

Move hardcoded content in footer out of layout #83

Closed maneesha closed 4 months ago

maneesha commented 5 months ago

The footer layout has a lot of hardcoded content.

This should be moved out of the footer layout so it can be modified for each site that uses this theme.

AdamChlan commented 5 months ago

@maneesha do you want the content from the footer to match what is in the main navigation? If so, we can pull that in. Or should it come from somewhere else? Or do you just want the content removed from the footer altogether and have each site hard code that in when ready?

maneesha commented 5 months ago

Remove from footer in the layout and have each site code in that content.

AdamChlan commented 4 months ago

@maneesha I have moved the hard coded content out of the layout, and included them as partials. They can be updated as needed on a site by site basis. Let me know if you need anything else here.

maneesha commented 4 months ago

@AdamChlan It looks like the content is still in the theme though. We'd want that moved to the site content so each site that uses this theme can customize the footer content.

AdamChlan commented 4 months ago

@maneesha We have a few options here for controlling this content. Please let me know if you have a preference or any questions.

  1. You can build the footer menus through the site config file. This is how the main navigation is being constructed.
  2. You can have a custom HTML file that will override the theme's footer partial
  3. Or we can allow for front matter flags to construct these footer menus. This in our opinion would be hardest to manage.
maneesha commented 4 months ago

By option 1 above, do you mean something like the menus.yaml file?

If so, I think that is what we would prefer to keep things consistent.

AdamChlan commented 4 months ago

@maneesha Yes, like the menus.yaml file. We can get that in place

maneesha commented 4 months ago

Following up on this, the links to the socials (Facebook, Twitter, etc.) should also be moved out of the theme and into the site content.

Icons should also only display if a link is provided in the site content.

AdamChlan commented 4 months ago

@maneesha I have the socials moved out to the menu file as well now