search

carpentries / varnish

Template for pkgdown site
https://carpentries.github.io/varnish/
Other
7 stars 25 forks source link

Consider bootstrap 4 implications #1

Closed zkamvar closed 2 years ago

zkamvar commented 3 years ago

There is a lot of discussion buzzing about the R community to switching over to bootstrap 4.

Examples:

https://github.com/r-lib/pkgdown/issues/1409 https://github.com/rstudio/rmarkdown/issues/1260 https://github.com/rstudio/rmarkdown/issues/1260#issuecomment-548004630

It may be worthwhile just to go with bootstrap4 from the get-go and see if we can tool around that.

zkamvar commented 3 years ago

I knew this would fail, but the first test with swapping out the script sources for bootstrap 4 and jQuery gives this monstrosity:

image of mis-rendered web page with 3 errors, 1 warning, and 85 debug flags

fmichonneau commented 3 years ago

bootstrap 5 is coming out soon, when using it with our own version of the template, we need to look into whether we should skip version 4 altogether.

zkamvar commented 3 years ago

I think we may want to start with 4 and migrate to 5 once the RMarkdown verse is also there. At the moment, they are still on 4, but are considering 5: https://github.com/rstudio/bslib/issues/82

One of the things I've been eyeing is using {bslib} and a custom RMarkdown template to control the theming. In theory, this should allow people to more easily customize the template for their use.