search

carpentries / varnish

Template for pkgdown site
https://carpentries.github.io/varnish/
Other
7 stars 25 forks source link

Bugfix: Lesson title would collide with search box at certain widths. #113

Closed Robadob closed 8 months ago

Robadob commented 9 months ago

Before image

After image

The rule sits within a media breakpoint so is only active between window widths 768-1200px, otherwise that particular element is display: none. Likewise, the search box appears to have a static size/position whilst visible (although the green magnifying glass does alot of walking about at widths >1200px). So I don't think this will introduce any new issues.

Closes #84

zkamvar commented 9 months ago

Would you mind ammending the NEWS.md file with your contribution?

zkamvar commented 9 months ago

Likewise, the search box appears to have a static size/position whilst visible (although the green magnifying glass does alot of walking about at widths >1200px).

This has been one of those frustrating bugs from the initial design that I haven't been able to pin down very well 😞

Robadob commented 9 months ago

Would you mind ammending the NEWS.md file with your contribution?

Sorted.

zkamvar commented 8 months ago

Thank you! I think this is a good solution.