Closed Robadob closed 8 months ago
Since the varnish template was updated to include translations, my local builds via sandpaper::serve() return empty string for translation symbols such as the below area.
varnish
sandpaper::serve()
which comes from this section of the (modified) template
<div class="col-md-5"> <p>Lesson developed by <a href="https://rse.shef.ac.uk">RSE</a> & <a href="https://www.sheffield.ac.uk/it-services/research">RIT</a></p> {{#yaml}} <p> {{^old-url}} <a href="{{#yaml}}{{source}}/edit/{{branch}}/{{/yaml}}{{file_source}}{{^file_source}}README.md{{/file_source}}">{{ translate.EditOnGH }}</a> {{/old-url}} {{#old-url}} {{#pre-beta-date}} <a href="{{#yaml}}https://carpentries.github.io/workbench/contributor/pre-beta.html?id={{source}}/edit/{{branch}}/{{/yaml}}{{file_source}}{{^file_source}}README.md{{/file_source}}">{{ translate.EditOnGH }}</a> {{/pre-beta-date}} {{^pre-beta-date}} <a href="{{#yaml}}{{source}}/edit/{{branch}}/{{/yaml}}{{file_source}}{{^file_source}}README.md{{/file_source}}">{{ translate.EditOnGH }}</a> {{/pre-beta-date}} {{/old-url}} {{/yaml}} | <a href="{{#yaml}}{{source}}/blob/{{branch}}/{{/yaml}}CONTRIBUTING.md">{{ translate.Contributing }}</a> | <a href="{{#yaml}}{{source}}/{{/yaml}}">{{ translate.Source }}</a></p> <p><a href="{{#yaml}}{{source}}/blob/{{branch}}/{{/yaml}}CITATION">{{ translate.Cite }}</a> | <a href="mailto:{{#yaml}}{{contact}}{{/yaml}}">{{ translate.Contact }}</a> | <a href="https://carpentries.org/about/">{{ translate.About }}</a></p> {{# translate.ThisLessonCoC }}<p>{{& translate.ThisLessonCoC }}</p>{{/ translate.ThisLessonCoC }} </div>
In contrast, the version built via GitHub actions, works as expected.
I can't spot any related warnings/errors in the sandpaper log from a clean build.
sandpaper
Likewise, I don't see anything related in the sandpaper docs.
I setup the dependencies, prior to sandpaper::serve() with the following R commands (but I'm not really an R user).
# Setup mirrors options(repos = c( carpentries = "https://carpentries.r-universe.dev/", CRAN = "https://cran.rstudio.com/" )) # Setup install from github install.packages("devtools") library(devtools) # Install Uni of Shef Varnish theme install_github("RSE-Sheffield/uos-varnish") # Install remaining official carpentries packages install.packages(c("sandpaper", "tinkr", "pegboard"))
I'm assuming I'm missing an additional dependency or build step.
Sorry if this isn't the appropriate repository for the issue.
Updating the other packages and doing a clean build fixed it. 🤦♂️ (I thought I'd set it up on this machine after the translations were merged)
Since the
varnish
template was updated to include translations, my local builds viasandpaper::serve()
return empty string for translation symbols such as the below area.which comes from this section of the (modified) template
In contrast, the version built via GitHub actions, works as expected.
I can't spot any related warnings/errors in the
sandpaper
log from a clean build.sandpaper::serve() log
``` > sandpaper::serve() ℹ Rebuilding C:/Users/robert/pando/pando-python ── Validating Fenced Divs ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── ── Validating Internal Links and Images ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── ! There were errors in 1/51 links ◌ Avoid uninformative link phrasesLikewise, I don't see anything related in the
sandpaper
docs.I setup the dependencies, prior to
sandpaper::serve()
with the following R commands (but I'm not really an R user).I'm assuming I'm missing an additional dependency or build step.
Sorry if this isn't the appropriate repository for the issue.