carpentries / varnish

Template for pkgdown site
https://carpentries.github.io/varnish/
Other
7 stars 25 forks source link

Upgrade Varnish to Bootstrap 5.3.2 #123

Closed astroDimitrios closed 2 months ago

astroDimitrios commented 7 months ago

Closes #77

What: Upgrades the version of Bootstrap that Varnish uses from 5.1.3 to 5.3.2.

Why: Bootstrap 5.3 introduced Colour Modes, a dark-mode and more options to customise themes which I would like to use in the Workbench.

In #77 a sass warning was mentioned which does not appear with 5.3.2. This is a relatively minor change - I can't see any differences to a lesson built with the newer Bootstrap but someone else should probably check too!

I also had to change a line in the squash-a-script script. This is because when building with the new Bootstrap version the dropdowns didn't work as they rely on popper.js - using the Bootstrap Bundle resolves this issue as it bundles popper.js with bootstrap.