Open olexandr-konovalov opened 4 months ago
Sorry for the delay in getting this tested @olexandr-konovalov. It took me a bit of learning to figure out how to render lessons using dovetail (although @joelnitta's guide here made things much clearer!).
I did get the ukranian-carpentries/git-novice lesson rendered locally with both the current version of varnish and the version included in this PR, however, I'm not seeing any difference in the rendered fonts (see screenshot below, official varnish on top, this PR on bottom):
It seems like the fonts you've loaded aren't being found?
For reference, the way to test with a custom version of varnish is to run the following in your R session:
install.packages(devtools)
library(devtools)
devtools::install_github("carpentries/varnish#133")
library(dovetail)
render_trans_from_branch(lang = "uk")
Pinging @froggleston here in case he knows more about where/how new fonts are integrated and if there's a setting I'm missing here.
Many thanks for testing this, @ErinBecker! Indeed, it does not change the fonts. Will be waiting to hear from @froggleston
Following the hints in #120, I have:
I haven't tested it, since I lack knowledge about building local version of the Carpentries lesson using custom version of varnish. I would be grateful if someone can test it (maybe build the lesson at https://github.com/ukrainian-carpentries/git-novice and post a screenshot of some page here) or point me to the instructions for building it myself.
Closes #120