carpentries / varnish

Template for pkgdown site
https://carpentries.github.io/varnish/
Other
7 stars 33 forks source link

Use a Sass variable for default font #151

Closed Bisaloo closed 4 weeks ago

Bisaloo commented 1 month ago

The goal of this PR is to facilitate theming in varnish forks.

Currently, forks that want to set their own fonts need to edit numerous files and it takes a lot of maintainance work to fix the various git conflicts that arise as a result when pulling from upstream.

By setting the font once as a Sass variable, this should reduce the difficulty of:

I'm definitely not a CSS or Sass expert but I have tested this locally and it works as expected as far as I can tell.

froggleston commented 4 weeks ago

Hey @Bisaloo - please could you merge in main/rebase this PR and we can move forward with it?

froggleston commented 4 weeks ago

LGTM! Thank you @Bisaloo !