search

carpentries / varnish

Template for pkgdown site
https://carpentries.github.io/varnish/
Other
7 stars 29 forks source link

Ordered lists do not render correctly in `solution` box #51

Closed tobyhodges closed 2 years ago

tobyhodges commented 2 years ago 
::: challenge

1. Monday
1. Tuesday
1. Wednesday
1. Thursday
1. Friday

:::::: solution

1. Saturday
1. Sunday

::::::

:::

becomes in the built page:

Screenshot of a challenge and solution block on an episode page, with the days of the week Monday through Friday appearing as a numbered list in the challenge body, and Saturday and Sunday listed without item markers in the solution body.

tobyhodges commented 2 years ago

The <ol><li> elements seem to be created correctly in the HTML, so maybe this issue belongs in https://github.com/carpentries/varnish/?

zkamvar commented 2 years ago

Yup, this is definitely an issue for {varnish}. I'll transfer the issue.

zkamvar commented 2 years ago

This is coming from

https://github.com/carpentries/varnish/blob/79b523d546544dc94ee5d4430224a1e2043a2100/source/stylesheets/sidenav.scss#L130-L132

because the solution has the .accordion-body class, which is also used for the side navigation menus. It's also worth mentioning that fixing this will make sure that list items are displayed correctly in instructor notes.

zkamvar commented 2 years ago

It should be fixed and will be available on the universe in about an hour or less