search

carpentries / varnish

Template for pkgdown site
https://carpentries.github.io/varnish/
Other
7 stars 29 forks source link

Update bootstrap version? #77

Closed zkamvar closed 4 months ago

zkamvar commented 1 year ago

At the moment, we are getting the following warning from sass:

DEPRECATION WARNING: $weight: Passing a number without unit % (100) is deprecated.

To preserve current behavior: $weight * 1%

More info: https://sass-lang.com/d/function-units

    ╷
201 │   @return mix(rgba($foreground, 1), $background, opacity($foreground) * 100);
    │           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
    source/stylesheets/bootstrap/scss/_functions.scss 201:11            opaque()
    source/stylesheets/bootstrap/scss/mixins/_table-variants.scss 4:2[8](https://github.com/carpentries/varnish/actions/runs/4408013382/jobs/7722459851#step:9:9)  table-variant()
    source/stylesheets/bootstrap/scss/_tables.scss 138:3                @import
    source/stylesheets/bootstrap/scss/bootstrap.scss 22:[9](https://github.com/carpentries/varnish/actions/runs/4408013382/jobs/7722459851#step:9:10)               @import
    source/stylesheets/styles.css.scss 1:9                              root stylesheet

I don't know if they fixed it in bootstrap, but it might be worth investigating.