carpentries / workbench

Repository for Discussions and Materials about The Carpentries Workbench
https://carpentries.github.io/workbench/
Creative Commons Attribution 4.0 International
17 stars 7 forks source link

Menu navigation changes from number to bullet point #42

Closed cynthiaftw closed 1 year ago

cynthiaftw commented 1 year ago

When I click on the menu let's say number 2 in a list. It changes to a bullet point so you don't know where you are. It should stay as a number 2. At first I thought it took me to a level down and took forever long for me to figure out it was not moving between levels just changing the number to a bullet. It is the worst and makes you loose yourself in the navigation. It is confusing to new users as well. You have a hard time directing people to the links - now I hoover and point out the change and have to click several times back and forth for people to follow in a lesson.

zkamvar commented 1 year ago

Thank you for opening this issue @cynthiaftw. From your description, this is definitely something that hinders accessibility (specifically I think it most pertinantly falls into the realm of the need for consistent navigation and should be fixed. At the moment, the side bar looks like this:

a screenshot of a sidebar with 8 numbered sections. The third section is bold with a bullet point and a secondary list of sections below it, but it has no number

Do you think adding the episode number would be a good solution to the problem you describe? The bullet point is there as an indicator that the it's the active section.

the same sidebar as above, but the third section has the number 3. appended before the text

cynthiaftw commented 1 year ago

This would be perfect, you could see that you are still where you thought you were going. Could also state to the class when directing people click on 3 and they would still see that is where they landed. I do think this is a great solution. Also I like that the bullet is there to indicate that is what you are reading.

Cynthia Henry College of Human Sciences Texas Tech University (806) 834-0898 @.**@.> http://guides.library.ttu.edu/hs Make an Appointmenthttps://cal.library.ttu.edu/appointments/libcal?u=48731

From: Zhian N. Kamvar @.> Sent: Thursday, March 30, 2023 8:51 AM To: carpentries/workbench @.> Cc: Henry, Cynthia @.>; Mention @.> Subject: Re: [carpentries/workbench] Menu navigation changes from number to bullet point (Issue #42)

This email originated outside TTU. Please exercise cautionhttps://askit.ttu.edu/phishing!

Thank you for opening this issue @cynthiaftwhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcynthiaftw&data=05%7C01%7Ccynthia.henry%40ttu.edu%7C88e38b04a17e4104ad5908db3125bd5d%7C178a51bf8b2049ffb65556245d5c173c%7C0%7C0%7C638157810386500744%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=eW4mcCx0AONcJtz0tCDRqFN4aNIhWiy4djbJp7YLIwU%3D&reserved=0. From your description, this is definitely something that hinders accessibility (specifically I think it most pertinantly falls into the realm of the need for consistent navigationhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.w3.org%2FWAI%2FWCAG21%2FUnderstanding%2Fconsistent-navigation.html&data=05%7C01%7Ccynthia.henry%40ttu.edu%7C88e38b04a17e4104ad5908db3125bd5d%7C178a51bf8b2049ffb65556245d5c173c%7C0%7C0%7C638157810386500744%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=9i7VXWEbvLIeNX5TdwzEhr33020ZXmuNut1g3zkJR%2FM%3D&reserved=0 and should be fixed. At the moment, the side bar looks like this:

[a screenshot of a sidebar with 8 numbered sections. The third section is bold with a bullet point and a secondary list of sections below it, but it has no number]https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F3639446%2F228854356-2680ddd7-7979-4891-bc1f-f63575bb6afb.png&data=05%7C01%7Ccynthia.henry%40ttu.edu%7C88e38b04a17e4104ad5908db3125bd5d%7C178a51bf8b2049ffb65556245d5c173c%7C0%7C0%7C638157810386500744%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ws23gZKciQzwUO8yXZFZ%2BMskNmv0FP51ZKxNi5C%2Ba7w%3D&reserved=0

Do you think adding the episode number would be a good solution to the problem you describe? The bullet point is there as an indicator that the it's the active section.

[the same sidebar as above, but the third section has the number 3. appended before the text]https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F3639446%2F228854154-98e8bd30-6fc1-4692-af03-95e905dd15e6.png&data=05%7C01%7Ccynthia.henry%40ttu.edu%7C88e38b04a17e4104ad5908db3125bd5d%7C178a51bf8b2049ffb65556245d5c173c%7C0%7C0%7C638157810386500744%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=OYAYR6t9uw6X%2BsZcXPOKf%2Bdo%2FEzRv9iIn4%2Fa99lHWqg%3D&reserved=0

- Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcarpentries%2Fworkbench%2Fissues%2F42%23issuecomment-1490341430&data=05%7C01%7Ccynthia.henry%40ttu.edu%7C88e38b04a17e4104ad5908db3125bd5d%7C178a51bf8b2049ffb65556245d5c173c%7C0%7C0%7C638157810386500744%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=5UBCVLpMbKd%2BoaqkKeYhQF8YaS3c5SkIvls1nTZCXxI%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAZQLSXK2EEYD7R44HOVZRSLW6WFSZANCNFSM6AAAAAAWMDDZOA&data=05%7C01%7Ccynthia.henry%40ttu.edu%7C88e38b04a17e4104ad5908db3125bd5d%7C178a51bf8b2049ffb65556245d5c173c%7C0%7C0%7C638157810386500744%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=qrIbB4w0kH5qEjf%2BzMx%2B1oQsRRf3fjpVd2U%2FIfZFXGg%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>

zkamvar commented 1 year ago

Hello, I've fixed this in https://github.com/carpentries/sandpaper/pull/472 and the new version of {sandpaper} will be available to all the lessons in about an hour. The lessons will all rebuild around 00:00 UTC on Tuesday. If you see no change after that, feel free to reopen the issue.