carpentries / workbench

Repository for Discussions and Materials about The Carpentries Workbench
https://carpentries.github.io/workbench/
Creative Commons Attribution 4.0 International
17 stars 7 forks source link

Question about new menu item "FIXME" under "More" in the top navigation #45

Closed emcaulay closed 1 year ago

emcaulay commented 1 year ago

I don't understand the "FIXME" menu option under the "More" menu for lessons that have been transitioned to Workbench. I see this in my lesson (lc-git: https://librarycarpentry.org/lc-git/reference.html) and also in another lesson I'm referring to (lc-spreadsheets: https://librarycarpentry.org/lc-spreadsheets/reference.html)

I'm pretty sure we didn't have that link in the Github versions, but I might be wrong.

Tagging, @carpentries/core-team-curriculum

zkamvar commented 1 year ago

Hi @emcaulay,

That is likely because the original version did not have a title (which was found to be a bug in the former template).

The solution is to edit that page and add change the title at the top from 'FIXME' to 'Reference'

zkamvar commented 1 year ago

Both of these pages should be documents that contain reference information for learners, namely a glossary, but it could be other reference material.

zkamvar commented 1 year ago

Thank you again for bringing this up, @emcaulay. Because of your reporting, I was able to find and correct the bug in my transition script. Moving forward, lessons will have the correct title for the reference page.

Please let me know if you would like me to create a pull request to fix the reference tite.

emcaulay commented 1 year ago

Awwww, that is so sweet of you to take the time to let me know. I feel really good that I was able to help the bigger project, and I wouldn’t have known that without your letting me know! Thank you! I love to contribute!

zkamvar commented 1 year ago

Hi @emcaulay, I will close this as I believe this issue has been fixed.