search

carpentries / workbench

Repository for Discussions and Materials about The Carpentries Workbench
https://carpentries.github.io/workbench/
Creative Commons Attribution 4.0 International
17 stars 7 forks source link

opening an episode page on a vertical screen results in squished text that doesn't unsquish when table of contents is minimized #64

Closed rbavery closed 1 month ago

rbavery commented 11 months ago

this isn't super pressing, since using vertical screens isn't common in a workshop setting. But when I open an episode on a vert screen, text gets squished. and it doesn't expand to take the full screen space when the table of contents is minimized.

https://esciencecenter-digital-skills.github.io/geospatial-python/11-parallel-raster-computations.html

Selection_039 Selection_040

cc @fnattino @rogerkuou

zkamvar commented 11 months ago

Hi @rbavery, this looks like the same issue as #57 and I'm afraid I cannot reproduce it. Do you see the same behaviour in an incognito window?

cc: @tobyhodges

rbavery commented 11 months ago

ah sorry about that. I looked at the issue and I couldn't reproduce it either when minimizing the window on a wide screen. To reproduce, I was opening the webpage on a vertical screen.

the issue doesn't happen when I paste the link into an incognito window for some reason. and after I disable all my adblock extensions and dark reader extensions and then re-enable them, I can't reproduce the issue. So I'm not sure which or how extensions are causing the issue but they seem to be the culprit here.

zkamvar commented 11 months ago

Thank you for following up with these details. This does help a bit because it confirms that it's an extension that's doing it.

IIRC, extensions work by manipulating the page contents to insert JS, HTML, or CSS. There is likely a clash of attributes that is happening with one of the extensions and The Workbench.

That being said, it's one of those frustrating problems that we cannot address until we figure out how to reproduce it. The only thing I would suggest is that the next time this happens, open the page in an incognito window (or in another browser), open an inspector, and then see if you can spot any differences in the <head> or <footer> elements.

froggleston commented 1 month ago

Fixed in https://github.com/carpentries/varnish/pull/109