search

carpentries / workbench

Repository for Discussions and Materials about The Carpentries Workbench
https://carpentries.github.io/workbench/
Creative Commons Attribution 4.0 International
17 stars 7 forks source link

child files not processed for validation #68

Open jcolomb opened 10 months ago

jcolomb commented 10 months ago

::::::::instructor is the right way to get instructor notes

:::::::: Instructor (Capital I) does not gives an error, but the text is then not in a box and not visible in the /instructornote.html view. It is still only visible in the "instructor view" of the course, but as normal text.

Is there a way to create error or warnings for the second div ?

zkamvar commented 10 months ago

Thank you for reporting this, @jcolomb! This is a feature for lessons, but in the context of child files, {pegboard} does not actually take them into account, which is clearly a bug!

I've opened https://github.com/carpentries/pegboard/issues/135 to track the issue. I will report back here when I've created a fix.

zkamvar commented 10 months ago

I am planning to release the fix for this tomorrow.