Formatting problems in instructor training callouts

carpentries / workbench

Repository for Discussions and Materials about The Carpentries Workbench

https://carpentries.github.io/workbench/

Creative Commons Attribution 4.0 International

17 stars 7 forks source link

Formatting problems in instructor training callouts #81

Closed ndporter closed 4 months ago

ndporter commented 5 months ago

Callouts in Instructor Training are displaying in CAPS UNDERLINE for all text (example).

It is not hard-coded that way in the episode and the pattern does not seem to hold for other lessons (I checked Data Carpentry Image Processing and the Maintainer Onboarding).

froggleston commented 5 months ago

At first glance, this is due to the callout-inner div seeming to have extra CSS properties:

<div class="section level3 callout-title callout-inner">

This should be:

<div class="callout-inner">

I'm unsure why these extra classes are being pulled in. I'll do some digging.

froggleston commented 5 months ago

Ah, it looks like a carbon copy of this bug, which is still open: https://github.com/carpentries/workbench/issues/59

And the rationale behind the issue is exactly the same as described here: https://github.com/carpentries/sandpaper/issues/470

The instructor-training pandoc version seems to be 3.1.11, whereas an example other lesson such as swcarpentry/shell-novice is using 2.19.2: https://github.com/swcarpentry/shell-novice/actions/runs/8057544038/job/22008835053#step:4:3

ErinBecker commented 4 months ago

Closed with https://github.com/carpentries/sandpaper/pull/574. Screenshot below confirms text of callouts is no longer all caps underline. Thanks @froggleston for the fix and @ndporter (and @brownsarahm for reporting in https://github.com/carpentries/varnish/issues/128).