search

carpentries / workshop-template

The Carpentries Workshop Template
https://carpentries.github.io/workshop-template/
Other
235 stars 521 forks source link

Slight update needed for Git bash for Windows installation instructions #754

Open mattagape opened 3 years ago

mattagape commented 3 years ago

Hi all

First, Sarah's very helpful video tutorial in setting up Git Bash for Windows is a little outdated; nano is now installed during the Git Bash installation, and the separate SWCarpentryInstaller.exe is no longer required. The step-by-step written instructions were obviously updated at some point to reflect this.

However, I was just going through the instructions on a new Windows laptop. The Git Bash installer has changed slightly (unless I missed this bit before!). It has an option about "Choosing the SSH executable".

So I think this stage should be made clear.

image

Presumably one should accept the default of "Use bundled OpenSSH".

elichad commented 3 years ago

I agree that clarification is needed here! This is a new feature in v2.32.0(2) (July 6th 2021).

Windows 10 does come with its own SSH client now, but I'm not sure if it's available by default or if you have to install it as an optional feature.

I would guess that bundled OpenSSH should be okay (I have both the Git and Windows 10 version installed and have no problems) but it could really do with testing on a fresh machine. @mattgillucl did you go through the course and test that it works?

mattagape commented 3 years ago

@elichad It works ok on my machine (TM), but I haven't gone through the course to test the installation.

mattagape commented 3 years ago

OK I fired up a git bash terminal, on a newish Windows 10 laptop (not used much), and successfully used ssh to log in to a remote machine.

$ which ssh
/usr/bin/ssh

So it looks like the bundled OpenSSH is OK.

elichad commented 2 years ago

I told attendees of my workshop (~50 people) to use the bundled OpenSSH option, and that didn't seem to cause any issues.