search

carpentrycon / carpentrycon2022

https://2022.carpentrycon.org
MIT License
6 stars 8 forks source link

Fix speaker page #75

Closed maneesha closed 2 years ago

maneesha commented 2 years ago

As discussed with @morskyjezek -- Updates speaker page so that keynotes are displayed with profiles and photos; others are in a simple list.

aws-amplify-us-east-1[bot] commented 2 years ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-75.dapx3gr2jx1wz.amplifyapp.com

morskyjezek commented 2 years ago

Me, too, looks great. This is what I had in mind. Would it be possible to add a spacer before the session presenters list so it doesn't overlap with the keynote photos? When I opened it on desktop, the flow of the list looks a bit strange since it starts in the keynote space and flows down to the rest of the page ...

column-overlap
maneesha commented 2 years ago

It displays well on wide screen and displays well on narrow screen/mobile. There are in-between screen sizes where it does what @morskyjezek shared. I'll explore this more next week to see if I can fix this (or at least make it look a little bit better).

morskyjezek commented 2 years ago

Yes, that display issue went away when I widened the window on my screen. Other than that small issue, this looks great to me. Thanks!

HaoZeke commented 2 years ago

I'm in favor of merging this now and tracking reflow issues and responsive design in a different issue/PR though.

morskyjezek commented 2 years ago

I agree. I'm going to try the merge now. Thanks!

morskyjezek commented 2 years ago

Looks good to go. I corrected the typo I had made in the speakers file in the following commit 4fa511bd4c5a65adb2209305b7b82b98285e4593