search

carr / phone

Ruby library for phone number parsing, validation and formatting
Other
394 stars 140 forks source link

Allows 9&11 digit North American phone numbers #25

Open jpaas opened 12 years ago

jpaas commented 12 years ago

Maybe I'm just not aware that these are valid, but the gem is allowing North American phone numbers with 9 and 11 digits. As far as I know only 10 digits are valid.

e.g.

ruby-1.9.2-p290 :017 > Phoner::Phone.parse "212-555-121", :country_code => '1' => +1212555121 ruby-1.9.2-p290 :018 > Phoner::Phone.parse "212-555-12", :country_code => '1' RuntimeError: Must enter area code or set default area code ruby-1.9.2-p290 :019 > Phoner::Phone.parse "212-555-12", :country_code => '1', :area_code => '666' => +166621255512

g1smd commented 11 years ago

The repo owner is AWOL. Your issue has already been ignored for 6 months.

Try the wmoxam/phone branch instead. The code there is much more actively maintained.

elskwid commented 11 years ago

I'm going to be making a pass through issues soon. See #41.