Undefined conversions, unused variables & comparison between expressions

[nabeelkirmani]

Undefined conversion:

line 45 should be const char OK_[] = "OK";

Unused variable

char resp[16]; in HTTP::get()

Comparisons between signed and unsigned expressions

int i in parseATResponse() could be unsigned int i int i = 0; in parseJSONResponse() could be unsigned int i = 0;

[carrascoacd]

Thanks for letting me know.

I'll pass a linter to the whole project also.

On Tue 24 Mar 2020, 11:47 a.m. Nabeel Kirmani notifications@github.com wrote:

Undefined conversion:

line 45 https://github.com/carrascoacd/ArduinoSIM800L/blob/d0fcfffa7d8df7a1e81fbef712f5ca26fd2418bc/src/GPRS.cpp#L45 should be const char OK_[] = "OK"; Unused variable

char resp[16]; https://github.com/carrascoacd/ArduinoSIM800L/blob/master/src/Http.cpp#L112 in Http.cpp Comparisons between signed and unsigned expressions

int i https://github.com/carrascoacd/ArduinoSIM800L/blob/master/src/Parser.cpp#L36 in parseATResponse() could be unsigned int i int i = 0; https://github.com/carrascoacd/ArduinoSIM800L/blob/master/src/Parser.cpp#L46 in parseJSONResponse() could be unsigned int i = 0;

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/carrascoacd/ArduinoSIM800L/issues/39, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBWFOEE7D47P6UKWPJZCCTRJCFVHANCNFSM4LSRP3BQ .

[carrascoacd]

Suggestions coming soon... https://github.com/carrascoacd/ArduinoSIM800L/pull/41