search

carrien / free-speech

Analysis and plotting code for speech neuroimaging experiments.
MIT License
4 stars 5 forks source link

Use the correct 'experiments' folder path on the iEEG Cart PC. #27

Closed Comeani closed 3 years ago

Comeani commented 3 years ago

Added a nested conditional to the ispc section of this code to check if the COMPUTERNAME environment variable of the computer it is called on matches that of the iEEG Cart PC, sets the experiment folder path accordingly. Grabbed the PC name from the last data collection's expt structure, would be great to sanity check this on the cart PC itself. Also updated helpdocs for this function.

carrien commented 3 years ago

What is the use case for this function on the cart (instead of get_exptSavePath)?

Comeani commented 3 years ago

I think it's more that the iEEG expt setup scripts currently use the iEEG specific savepath functions, so if you were testing on a different machine they would be looking for the saalman lab folder by default. You could pass in an expt with your desired datapath to get around it, but this makes that automatic. Another question is if we want a single function conditionally handling edge cases (like the above), or separate functions for the other special machines we have software on (Cart PC, Caffeine, etc.). Also looking into it, get_exptSavePath.m is a function in free-speech/utils that get_exptLocalPath.m has the same functionality as except that exptSavePath does not handle the mac vs pc distinction. Is it possible that was kept around for backwards compatibility purposes?

carrien commented 3 years ago

Yes, I'm saying I don't see why get_exptLocalPath is used anywhere (and therefore why it needs to change). It would make sense to me to add this functionality to get_exptSavePath, which is used.

Comeani commented 3 years ago

Created pull requests in current-studies and free speech to shift edge case handling to a single exptSavePath function. Closing this in favor of those.