carrien / free-speech

Analysis and plotting code for speech neuroimaging experiments.
MIT License
4 stars 5 forks source link

single exptSavePath function, conditionally handling edge cases instead of those being separate scripts #31

Closed Comeani closed 2 years ago

Comeani commented 3 years ago

Add switch statement for handling iEEG/MRI PCs to exptSavePath, remove get_exptSavePath_mac (unused by any Lab Repo code).

This pull request will need to be merged at the same time as the pull request of the same name in current-studies to not break anything.

We should also consider that this function and the acoustSavePath function that accompany it (used in many different experiments) and get_exptLocalPath/get_acoustLocalPath/get_acoustLocalPaths (used in attentioncomp, some plotting functions, and most importantly the modelExpt function that new experiments might draw on as a template) are very similar in their functionality. I think it would be best to have the exptSavePath and acoustSavePath functions subbed in where localPath functions are being used to keep everything consistent.

Also, there could be confusion with get_exptPath existing, but that is only used in one or two instances and returns a path to Carries local user documents.