Closed cwnaber closed 1 year ago
Thanks, Chris. I want to be careful about how different defaults interact with each other; it's not clear to me why we set defaults inside this function and also with set_exptDefaults(exptPre). Can we just do the latter?
The default parameters set here are different than each of the default parameters in set_exptDefaults
. This function is specifically for the purpose of running the LPC check pretest phase. I set these defaults based on what the majority of functions are currently using as their settings during the LPC check pretest phase.
EDIT 4/13/23: The following message isn't what you were suggesting and isn't relevant. To your suggestion, it's possible that we could change the values in set_exptDefaults to try to better align with what we want during the LPC check pretest phase. But it's not clear to me that on a conceptual level that's what we want the values in set_exptDefaults to be determined by. Also, I wouldn't feel comfortable changing the values in set_exptDefaults without doing a fair amount of research, since it's used so extensively.
@carrien I integrated your comments, and this is ready for re-review.
Replaced by #94
! Replaced by #94
This function can be called in contexts where the experiment-programmer wants to collect information about a participant's LPC order or default vowel space area in a pretest phase. Previously, this was achieved by similar or identical lines of code being used in many run_..._expt functions.
This function adds a few features rarely implemented in other experiments:
nlpc.mat
was actually saved. (It might not be saved if the experimenter chooses "Exit without saving" from within the check_audapterLPC GUI.) If no file was saved, this function re-collects speech samples.All of the parameters of
exptPre
in this function can be overwritten. The coder simply needs to set those fields in exptPre before callingrun_checkLPC
. For example:Other pull requests in the repos current-studies and cerebellar-battery depend on this pull request. They should be merged at the same time.