carrien / free-speech

Analysis and plotting code for speech neuroimaging experiments.
MIT License
4 stars 5 forks source link

Create function run_checkLPC #69

Closed cwnaber closed 1 year ago

cwnaber commented 1 year ago

! Replaced by #94

This function can be called in contexts where the experiment-programmer wants to collect information about a participant's LPC order or default vowel space area in a pretest phase. Previously, this was achieved by similar or identical lines of code being used in many run_..._expt functions.

This function adds a few features rarely implemented in other experiments:

All of the parameters of exptPre in this function can be overwritten. The coder simply needs to set those fields in exptPre before calling run_checkLPC. For example:

exptPre.words = {'bead' 'bad' 'booed' 'bod'};     % sets stimulus words
exptPre.nblocks = 5;                              % sets number of repetitions of each word
expt = run_checkLPC(expt, exptPre);

Other pull requests in the repos current-studies and cerebellar-battery depend on this pull request. They should be merged at the same time.

carrien commented 1 year ago

Thanks, Chris. I want to be careful about how different defaults interact with each other; it's not clear to me why we set defaults inside this function and also with set_exptDefaults(exptPre). Can we just do the latter?

cwnaber commented 1 year ago

The default parameters set here are different than each of the default parameters in set_exptDefaults. This function is specifically for the purpose of running the LPC check pretest phase. I set these defaults based on what the majority of functions are currently using as their settings during the LPC check pretest phase.

EDIT 4/13/23: The following message isn't what you were suggesting and isn't relevant. To your suggestion, it's possible that we could change the values in set_exptDefaults to try to better align with what we want during the LPC check pretest phase. But it's not clear to me that on a conceptual level that's what we want the values in set_exptDefaults to be determined by. Also, I wouldn't feel comfortable changing the values in set_exptDefaults without doing a fair amount of research, since it's used so extensively.

cwnaber commented 1 year ago

@carrien I integrated your comments, and this is ready for re-review.

cwnaber commented 1 year ago

Replaced by #94