Fix class level asset_host_public config

carrierwaveuploader / carrierwave-aws

AWS-SDK storage adapter for CarrierWave

MIT License

409 stars 107 forks source link

Closed artygus closed 4 years ago

artygus commented 4 years ago

Currently it's possible to set asset_host_public setting in config, but it doesn't get applied. It turns out it only works if set in uploader.

artygus commented 4 years ago

I see https://github.com/sorentwo/carrierwave-aws/issues/141 and it seems the asset_host_public setting is being deprecated, but I don't see why, it is a really neat feature which solves https://github.com/carrierwaveuploader/carrierwave/issues/1986

sorentwo commented 4 years ago

I'm fine with diverging from carrierwave on this one. Nicely implemented as well 👍