search

carrierwaveuploader / carrierwave-google-storage

Carrierwave storage adapter that supports Google Cloud Storage and is based on gcloud library from Google
MIT License
62 stars 72 forks source link

Allow newly uploaded assets from an active record mount automatically be set to publicly available if bucket is set to public #7

Closed johnmcconnell closed 3 years ago

johnmcconnell commented 7 years ago

For example include the ACL defintion in: https://github.com/metaware/carrierwave-google-storage/blob/master/lib/carrierwave/storage/gcloud_file.rb#L72

From ACL definition here: http://googlecloudplatform.github.io/google-cloud-ruby/#/docs/google-cloud-storage/v1.4.0/google/cloud/storage/bucket?method=create_file-instance

johnmcconnell commented 7 years ago

This works fine if you configure gcloud directly with public permissions, so it may not be necessary to implement.

jasdeepsingh commented 7 years ago

@johnmcconnell let me know if this issue can be closed or you still need assistance with this?

johnmcconnell commented 7 years ago

I'd leave it open but mark it as low priority.

johnmcconnell commented 7 years ago

IMO, if you configure the library to make assets public it should update the ACL definitions in gcloud to allow a non public bucket to publicly share assets uploaded via this library.

jasdeepsingh commented 7 years ago

@johnmcconnell I'll be working on this issue within the next week. Need this functionality for my own app.

jasdeepsingh commented 5 years ago

I think it's about time to add proper ACL support to this library. I'll be tracking this development on this issue here.

Same feature mentioned in #25 as well. Closing #25 in favor of this issue.

jasdeepsingh commented 3 years ago

This should be resolved in the latest release on Rubygems:

https://rubygems.org/gems/carrierwave-google-storage/versions/1.0.0

Please re-open the issue if it's still an issue.