Test against Ruby 3.2 in CI for 1.x - Githubissues

carrierwaveuploader / carrierwave

Classier solution for file uploads for Rails, Sinatra and other Ruby web frameworks

https://github.com/carrierwaveuploader/carrierwave

8.78k stars 1.65k forks source link

Test against Ruby 3.2 in CI for 1.x #2699

Closed marcogregorius closed 9 months ago

marcogregorius commented 10 months ago

This PR targets the 1.x-stable branch.

Adding Ruby 3.2 for tests in CI.
Use latest rmagick for Ruby 3.2 as rmagick 2.16.0 calls the deprecated rb_obj_tainted
- Also fix the usage for the newer rmagick version to use ::Magick::Image.new(width, height) { |img| img.background_color = ...} pattern.

More context on why 1.x is still being used: https://github.com/carrierwaveuploader/carrierwave/pull/2640#issuecomment-1323532577.

Would also appreciate if the maintainer could release a new gem for 1.x 🙏

mshibuya commented 9 months ago

Thanks, just released 1.3.4.