Closed jescalan closed 10 years ago
Ok @kylemac, edited the description (really hard to explain this in an overview sense) and added a wonderful svg of the diagram!
So this is looking pretty good, we're at 99% coverage and really only need one more test to ensure that every part of the websocket functionality is working smoothly (connecting and disconnecting with multiple clients, which I still have to figure out how to do with websocket-driver
).
I'm going to merge this in, all that's left here other than that one test is the CLI which I'll be working on tomorrow!
So this refactor moves around a bit of logic. The biggest change is that all the websocket methods now go directly on the server object rather than the app object. This is because these methods can't be executed anyway when the server hasn't been started, so they might as well be added to the server itself. Other changes made here include:
client_open
andclient_close
emitted from the server to indicate when a client has connected and disconnected via websockets