search

carrot / roots-browserify

Roots v3 extension that uses browserify as a javascript pipeline
Other
21 stars 8 forks source link

roots compile when using browserify due to missing module uglifyify #12

Closed samccone closed 9 years ago

samccone commented 9 years ago

I can PR this if you want...

jescalan commented 9 years ago

Could you be a little more clear about what the issue actually is?

samccone commented 9 years ago

looks like doing a compressed compile using browserify it uses uglifyify .. but uglifyify is not a dep of this project

samccone commented 9 years ago

oh nm it is.. but seeing this issue still ... investigating

samccone commented 9 years ago

yeah this line... seems suspicious

https://github.com/carrot/roots-browserify/blob/f62c1473b7bef43529c15f92c450f5ef4065f11c/lib/index.coffee#L46

looks like it is looking at my local node_modules and not deeply looking for it.. still not 100% why this is happening

jescalan commented 9 years ago

Oh yeah maybe just require it and pass the object through directly instead of that string way of doing it then. I always thought that was suspect anyway, but browserify accepts transforms as strings then requires them, and it works in the tests which is why I left it. But see if changing that to the actual required library rather than a string works (that is a valid way to pass it, I only went with string because it worked and was less code)

samccone commented 9 years ago

yep for sure, I see why the tests work, but I can see why it does not work externally. cool beans

jescalan commented 9 years ago

Did it work making that change though?

jescalan commented 9 years ago

Merged and shipped as 0.3.0 :tada: -- thanks for catching this @samccone

samccone commented 9 years ago

bam