carrot / roots-browserify

Roots v3 extension that uses browserify as a javascript pipeline
Other
21 stars 8 forks source link

after_hook seems to be called twice #18

Closed samccone closed 9 years ago

samccone commented 9 years ago

browserify is a costly operation, it seems like we are calling the after hook on file change twice.

any thoughts @jenius ?

jescalan commented 9 years ago

I'm going to look into this today. Is there any more info you can drop for me here?

jescalan commented 9 years ago

I am currently stripping watchify and implementing the cache the right way, through roots and its own watcher. While running tests I am unable to reproduce this issue, all hooks are running the right amount of times. Perhaps it was something to do with the double watcher, etc.

Going to close for now