search

carrot / roots-browserify

Roots v3 extension that uses browserify as a javascript pipeline
Other
21 stars 8 forks source link

Add browserify injector #24

Closed SevereOverfl0w closed 7 years ago

SevereOverfl0w commented 8 years ago

https://github.com/carrot/roots-browserify/issues/23 should satisfy this.

jescalan commented 8 years ago

Lovely. Good work, thanks @SevereOverfl0w!

jescalan commented 8 years ago

Two small comments before merge:

  1. Could you squash be065e8 and 1ce2820 together?
  2. Could you document this feature in the readme?
SevereOverfl0w commented 8 years ago

Is there any way for me to see what way I've reduced coverage? I have an idea, but I'd like to know specifically.

kylemac commented 8 years ago

@SevereOverfl0w one way is to run the coverage script locally, npm run coverage

https://github.com/carrot/roots-browserify/blob/master/package.json#L51

SevereOverfl0w commented 8 years ago

Ah, didn't even think to look for that. Looks like the issue is that I don't at any point test for unprefixed calls.. hmm... may have an idea for that.

On 21 September 2015 at 18:45, Kyle MacDonald notifications@github.com wrote:

@SevereOverfl0w https://github.com/SevereOverfl0w one way is to run the coverage script locally, npm run coverage

https://github.com/carrot/roots-browserify/blob/master/package.json#L51

— Reply to this email directly or view it on GitHub https://github.com/carrot/roots-browserify/pull/24#issuecomment-142056547 .

SevereOverfl0w commented 8 years ago

Okay, resolved. Thanks for that @kylemac.