extensions are hardcoded in constructor

carrot / roots-browserify

Roots v3 extension that uses browserify as a javascript pipeline

Other

21 stars 8 forks source link

extensions are hardcoded in constructor #28

Closed liitfr closed 7 years ago

liitfr commented 7 years ago

Hello !

In index.coffee, I read :

      @b = browserify
        entries: @files
        extensions: ['.js', '.json', '.coffee']
        debug: opts.sourceMap
        cache: @cache
        packageCache: @pkg_cache

shouldn't it use opts.opts.extensions ?

See you. Mat

Edit : I will add it in my PR !

jescalan commented 7 years ago

Definitely, good catch! Want to send in a PR to fix this, get the first contribution under your belt? 😁

liitfr commented 7 years ago

fixed in #29