search

carrot / roots-browserify

Roots v3 extension that uses browserify as a javascript pipeline
Other
21 stars 8 forks source link

Update to uglifyify with fixed 'sourceMap' name #30

Closed J-Sek closed 7 years ago

J-Sek commented 7 years ago

sourcemap (before uglifyify@4.0.1) is causing source maps to be generated every time minify option is set to true. See the issue backing latest commit.

It causes roots compile to fail because source map is generated next to script content and uglify refuses to minify with message:

TypeError: path must be a string or Buffer while parsing file: ...\website\assets\js\main.coffee
    at Object.fs.openSync (fs.js:1:1)
    at Object.fs.readFileSync (fs.js:1:1)
    at Object.exports.minify (...\website\node_modules\uglify-js\tools\node.js:1:1)
    at Stream.ready (...\website\node_modules\roots-browserify\node_modules\uglifyify\index.js:1:1)
    at Stream.<anonymous> (...\website\node_modules\roots-browserify\node_modules\uglifyify\index.js:1:1)
coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 87effa805755ec51e0860646825fdc91744f2ab0 on J-Sek:upgrade-uglifyify into on carrot:master.

J-Sek commented 7 years ago

Would be great if anyone could bump to 0.6.1 and publish to NPM. :)

jescalan commented 7 years ago

You got it, publishing now