search

carrot / roots-browserify

Roots v3 extension that uses browserify as a javascript pipeline
Other
21 stars 8 forks source link

update browserify #9

Closed hhsnopek closed 9 years ago

hhsnopek commented 9 years ago

Alright so this is actually very close to being complete, I think. I just need to create a promise for L105, stream.pipe.

Basically we need to figure out how to verify browserify has completed. bundle() itself can return a callback, @jenius any ideas on how to convert that to a promise; I've tired when/node.call. Edit: or the stream itself; I'm attempting to listen for end to be emitted from pipe

closes #5

hhsnopek commented 9 years ago

EDIT: @jenius So everything is compiling correctly except Transforms!! yay - now to figure out why underscore is attempting to be required.

jescalan commented 9 years ago

can you rebase this on top of the latest master?

hhsnopek commented 9 years ago

the test checks if it exists, which it shouldn't so it passes; should.be.not.ok

coveralls commented 9 years ago

Coverage Status

Coverage remained the same when pulling 84fdf4f9e58387c5b9749568141c80422bb155c7 on update-browserify into afe3aa5f306958edd7e8f1a2223a7272bb1da253 on master.