carrot / share-button

:warning: :warning: Currently Unmaintained :warning: :warning: - fast, beautiful, and painless social shares:
http://sharebutton.co/
Other
2.95k stars 381 forks source link

Facebook app_id is actually appId. #284

Closed joelmats closed 8 years ago

joelmats commented 8 years ago

In the docs, it says to use app_id to specify this but in the code, it's actually looking for appId. https://github.com/carrot/share-button/blob/master/src/share-button.js#L641

hhsnopek commented 8 years ago

oh wow, I'm sorry about that! Thank you for bringing that up! - would you be able to update the docs and create a PR?

joelmats commented 8 years ago

Will do. Cheers!

hhsnopek commented 8 years ago

fixed in #288

hhsnopek commented 8 years ago

:smile: