When loading fb share with the sdk loaded, I am getting both pop up.

carrot / share-button

:warning: :warning: Currently Unmaintained :warning: :warning: - fast, beautiful, and painless social shares:

http://sharebutton.co/

Other

2.95k stars 381 forks source link

When loading fb share with the sdk loaded, I am getting both pop up. #285

Closed joelmats closed 8 years ago

joelmats commented 8 years ago

Commenting out these lines worked in eliminating the "sharer.php" from popping up: https://github.com/carrot/share-button/blob/master/src/share-button.js#L496-L498

hhsnopek commented 8 years ago

Hey @joelmats - is this the same issue as #266?

joelmats commented 8 years ago

@hhsnopek This is slightly different. Basically, the FB SDK version opens and then right after the sharer.php version in a new window also opens because i think the href is being set when it's not suppose to.