search

carrot / share-button

:warning: :warning: Currently Unmaintained :warning: :warning: - fast, beautiful, and painless social shares:
http://sharebutton.co/
Other
2.95k stars 381 forks source link

https #32

Closed robertjwhitney closed 10 years ago

robertjwhitney commented 10 years ago

Well, first I removed the protocal from the calls out to the font stylesheets, but welove fonts doesn't work over https so that's out. Related is that I don't really want to load two entire font sets for a an icon and a little bit of text...

robertjwhitney commented 10 years ago

I think one option might be to let me load the font set locally or specify another font via a config option.

jescalan commented 10 years ago

Yeah, definitely true. I'm working on a way to slim down the options as much as possible, externalize stylesheets, and boost the load time, but have been fighting cross-browser rendering. I can put what I have up on a branch if you want

robertjwhitney commented 10 years ago

Nah it's cool. I just made a branch that uses https://github.com/lwe/entypo-rails for my purposes.

debugger22 commented 10 years ago

Isn't this issue like those where people use http:// instead of // ?

tmilewski commented 10 years ago

This has been fixed via https://github.com/carrot/share-button/commit/477236c786844780496a3d33dd3d02ee2d475c72

@robertjwhitney I've also paired down the Google font via their awesome text parameter. It should now be about ~1/20th of the size.

debugger22 commented 10 years ago

I'm still facing the issue. Check footer of https://www.ubiplug.com/awair/

tmilewski commented 10 years ago

@mrsud Your site doesn't appear to work.

Also, are you using the most up-to-date version of the repository? At this point, use what's on master and not in releases.

debugger22 commented 10 years ago

Yeah, I just downloaded the js file present in build folder of master.

On Wed, Feb 12, 2014 at 9:46 AM, Tom Milewski notifications@github.comwrote:

@mrsud https://github.com/mrsud Your site doesn't appear to work.

Also, are you using the most up-to-date version of the repository? At this point, use what's on master and not in releases.

Reply to this email directly or view it on GitHubhttps://github.com/carrot/share-button/issues/32#issuecomment-34837432 .

tmilewski commented 10 years ago

@mrsud ok, let me know when your site is live again and I'll check it out.

debugger22 commented 10 years ago

It's live.

On Wed, Feb 12, 2014 at 9:51 AM, Tom Milewski notifications@github.comwrote:

@mrsud https://github.com/mrsud ok, let me know when your site is live again and I'll check it out.

Reply to this email directly or view it on GitHubhttps://github.com/carrot/share-button/issues/32#issuecomment-34837607 .

tmilewski commented 10 years ago

@mrsud https://cloudup.com/cv97gKQ4xd3

debugger22 commented 10 years ago

@tmilewski http://i.imgur.com/WYR03Rr.png

debugger22 commented 10 years ago

I'm very sorry, I don't know why the site is not available for you.

tmilewski commented 10 years ago

@mrsud I was able to recreate the issue. It's simply a caching issue on our CDN. I have purged the file in question and you should see it work in a short while. Sorry about that.

debugger22 commented 10 years ago

Thank you! It's working now.

robertjwhitney commented 10 years ago

:thumbsup: