carrot / ship

⛔️ currently unmaintained ⛔️
Other
151 stars 14 forks source link

only upload only changed files #16

Closed kylemac closed 10 years ago

kylemac commented 10 years ago

The grunt-aws-s3 plugin apparently does a nifty trick of comparing MD5 hashes of the files to assure only updated files are uploaded. I feel like this is extremely valuable, especially for a service like S3 which charges by requests (even if negligible).

The logic is defined in the readme - https://github.com/MathieuLoutre/grunt-aws-s3#optionsdifferential and located over here

jescalan commented 10 years ago

Awesome - this would be a great enhancement. 1000 dogecoin to whoever tackles this one first (if it's not me :grinning: )

hhsnopek commented 10 years ago

node-md5 currently looks like the most stable to create the md5sums with. Node.js has crypto built in but it's currently unstable and the api is being revised for later versions.

The best way would probably be reading from a file:

index.html: hash
main.css: hash
main.js: hash
imgs: hash
    flowers.jpg: hash
jescalan commented 10 years ago

I'd be comfortable with using built-in crypto, honestly. We're using it in the most basic way, and if things break we can just patch and fix.

hhsnopek commented 10 years ago

I'm currently re-organizing ship, and adding this in

jescalan commented 10 years ago

Ok, make sure to open a pull request early and check in with us often. Re-organizing is a big step, so working with us on that is important.

hhsnopek commented 10 years ago

@jenius Alright, I'll open a PR and summarize my changes

notslang commented 10 years ago

this will likely be a part of nsync, rather than ship

samccone commented 10 years ago

indeed https://www.youtube.com/watch?v=Eo-KmOd3i7s&feature=kp

hhsnopek commented 10 years ago

:baby: Bye Bye! :dancers: :dancers: