search

carrot / ship

⛔️ currently unmaintained ⛔️
Other
151 stars 14 forks source link

Tumblr deployer #35

Closed nporteschaikin closed 10 years ago

nporteschaikin commented 10 years ago

Based on this; re-PR'ed off develop.

notslang commented 10 years ago

I like it. There are a bunch of places where there's a blank line after the function sig, which is a little weird. But besides that it looks great!

jescalan commented 10 years ago

Ok, so rebasing this is not feasible at the moment, since it was based on top of a branch which is now not part of master. I tried to get through it, but it was too messy. I think instead I'm going to try to pull the relevant logic out and open a new PR, or force push over this one. Most of it is fairly contained anyway :grinning:

jescalan commented 10 years ago

Closing in favor of #43