search

carrot / ship

⛔️ currently unmaintained ⛔️
Other
151 stars 14 forks source link

Launch browser window on deploy #9

Closed hhsnopek closed 10 years ago

hhsnopek commented 10 years ago

Reference: roots issue #305

This doesn't seem like it belongs to roots, could be a nice feature for ship. Possible configuration to turn this off as well within the ship.config when the user sets up the config file?

jescalan commented 10 years ago

I'm thinking actually that this should be a part of roots and not ship. Ship will return a url that the website was deployed to, and the option to open after deploy could be in app.coffee? It just seems a little out of scope for ship, which is only for deploying. Roots handles a lot of the automated stuff like live reloads, opening the browser window, the watcher etc.

hhsnopek commented 10 years ago

Only reason I thought it should go here is if others were to use ship without roots. Rethinking this does seem out of scope for ship. Will ship return a url, which then roots will use to open a browser window?

jescalan commented 10 years ago

Exactly. And if someone else were building ship into an interface, they would be free to take the url and open it as well :smile:

hhsnopek commented 10 years ago

Awesome! Glad I figured that out