Closed dynbabaul closed 1 month ago
Hey @dynbabaul, thanks for your contribution!
I see you've made some interesting changes to the program, especially the timeout feature and the mouse movement behavior.
However, it turns out that both of these functionalities are already built into the program and the operating system:
The timeout
program on Linux allows you to set a runtime limit for any command, similar to your proposed timeout feature.
timeout 30s keep-presence
The --circular
option in the program itself already achieves the mouse movement behavior you described, where it moves and returns to the original position.
keep-presence --seconds 1 --pixels 1 --circular
Because these features already exist, I won't be merging this pull request in its current form.
But that doesn't mean your contribution wasn't valuable! It's great that you identified these potential improvements and took the initiative to code them.
Perhaps you have other ideas for improvements that aren't currently implemented? Feel free to share them, and we can discuss how they might fit with the project.
Thanks again for your contribution!
I was using the timeout in Linux but decided I liked it better to be part of the program itself is why I added that. Then if that option is not available in the OS it' still in the program, since python can run on other OSs too.
Sorry you didn't like the changes, they were just personal preference and I thought I'd share.
Hi @dynbabaul,
Thank you for explaining your reasoning behind the changes. I understand the desire to have these features built into the program for consistency across different operating systems.
However, I prioritize keeping this program as simple as possible and focused on Linux-specific features. By leveraging existing tools and functionalities available in Linux, we can avoid adding extra complexity to the codebase.
I appreciate your effort and contribution. If you have any other ideas or suggestions that align with keeping the program lightweight and Linux-centric, I'd be happy to discuss them.
Thanks again for your understanding and contributions!
Ignore the changes to the README file, I changed that to reflect my branch of this and 99% of it is irrelevant. Just the help output may be useful.
The changes I made I think may be of use are to the program itself.
I didn't like the mouse traveling down the page so I changed that to when it moves the mouse it then moves it back to it's original position.
Next I added a timeout feature. You can set it to run for 30 minutes or 8 hours. Even seconds, not that it's really useful, I just added it anyhow though, mainly for testing.
I added this because I use it on a spare computer that I use when I work to listen to podcasts. I want this to run for 8 hours and then turn off. I don't want to forget and then it keeps the monitor on all night.