search

carson-katri / dream-textures

Stable Diffusion built-in to Blender
GNU General Public License v3.0
7.77k stars 415 forks source link

linux-rocm requirements don't pull torch-rocm #809

Closed aaaaaaaaargh closed 4 weeks ago

aaaaaaaaargh commented 1 month ago

Description

As already mentioned in #803, manually installing the dependencies using the provided linux-rocm requirements file is not working as expected.

Steps to Reproduce

  1. Clone the repository in your scripts/addons folder as described in the documentation.
  2. Run /usr/share/blender/4.1/python/bin/python3.11 -m pip install -r requirements/linux-rocm.txt --target .python_dependencies in the checked out folder

Expected Behavior

A rocm version of PyTorch (>=2.3.1) should have been downloaded but instead it is downloading the default one withtout rocm support.

This is due to requirements/linux-rocm.txt referring to the extra-index-url https://download.pytorch.org/whl/nightly/rocm6.1/ which is only containing nightly versions and from my understanding the version constraint >=2.3.1 does not apply. Changing the extra-index-url to https://download.pytorch.org/whl/rocm6.1/ seems to fix the problem and I couldn't find any issues when using the addon in blender.

(Also, as a side note, the dropdown in the bug reporting form should be updated because the current gen AMD GPUs are supported now)

Addon Version

Other (Built from source)

GPU

AMD (unsupported for local generation)

carson-katri commented 1 month ago

I don't have a Linux machine to test with, can you confirm this PR looks correct? https://github.com/carson-katri/dream-textures/pull/811