search

carson-katri / swift-request

Declarative HTTP networking, designed for SwiftUI
MIT License
730 stars 41 forks source link

`BuildIf` realization #13

Closed EgorKolyshkin closed 4 years ago

EgorKolyshkin commented 4 years ago

I added buildIf for Request Builder and expanded logic in order to handle multiple Urls cases. I think it would be nice to test fatalErrors some time.

codecov-io commented 4 years ago

Codecov Report

Merging #13 into dev will increase coverage by 1.44%. The diff coverage is 95%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #13      +/-   ##
==========================================
+ Coverage   65.87%   67.31%   +1.44%     
==========================================
  Files          21       21              
  Lines         545      566      +21     
==========================================
+ Hits          359      381      +22     
+ Misses        186      185       -1
Impacted Files Coverage Δ
Tests/RequestTests/RequestTests.swift 96.35% <100%> (+1.99%) :arrow_up:
Sources/Request/Request/RequestBuilder.swift 81.25% <90.9%> (+6.25%) :arrow_up:
Sources/Request/Request/Request.swift 78.31% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d57d6ea...46a7390. Read the comment docs.

carson-katri commented 4 years ago

Thanks for the contributions!