search

carson-katri / swift-request

Declarative HTTP networking, designed for SwiftUI
MIT License
727 stars 41 forks source link

Improve test coverage #22

Closed ezraberch closed 4 years ago

ezraberch commented 4 years ago

This PR adds and modifies tests to improve test coverage. Additionally, two Json bugs which would cause the new tests to fail are fixed. Basically, what remains uncovered is SwiftUI code, fatalError lines, and lines I'm pretty sure are unreachable.

The second commit removes an unnecessary second call of the Request builder closure.

codecov-io commented 4 years ago

Codecov Report

Merging #22 into master will increase coverage by 17.89%. The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #22       +/-   ##
===========================================
+ Coverage   67.88%   85.77%   +17.89%     
===========================================
  Files          21       21               
  Lines         576      682      +106     
===========================================
+ Hits          391      585      +194     
+ Misses        185       97       -88
Impacted Files Coverage Δ
Sources/Json/Literals.swift 66.66% <33.33%> (+41.66%) :arrow_up:
Tests/RequestTests/RequestTests.swift 92.94% <90.82%> (-2.16%) :arrow_down:
Sources/Json/Json.swift 98.78% <100.00%> (+22.23%) :arrow_up:
Sources/Request/Request/Request.swift 95.12% <100.00%> (+13.51%) :arrow_up:
Tests/RequestTests/JsonTests.swift 84.61% <100.00%> (+3.13%) :arrow_up:
Sources/Request/Request/RequestBuilder.swift 86.66% <0.00%> (+5.41%) :arrow_up:
Sources/Request/Request/Extra/RequestChain.swift 100.00% <0.00%> (+19.23%) :arrow_up:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d297a4...b015d25. Read the comment docs.

carson-katri commented 4 years ago

Amazing job, thank you.