o-nnerb commented 4 years ago

As mentioned in #30, the actual implementation of RequestError was removing other types of errors like the URLError, so the application cannot cast and verify what error occurred exactly. Now, the onError callback will have as a parameter a value of Error type and the application can cast it to RequestError or to URLError.

codecov-commenter commented 4 years ago

Codecov Report

Merging #31 into master will decrease coverage by 0.47%. The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   86.03%   85.55%   -0.48%     
==========================================
  Files          21       22       +1     
  Lines         716      720       +4     
==========================================
  Hits          616      616              
- Misses        100      104       +4

Impacted Files	Coverage Δ
Sources/Request/Helpers/RequestError.swift	`0.00% <0.00%> (ø)`
Tests/RequestTests/RequestTests.swift	`93.28% <50.00%> (ø)`
Sources/Request/Request/Extra/RequestChain.swift	`100.00% <100.00%> (ø)`
Sources/Request/Request/Extra/RequestGroup.swift	`100.00% <100.00%> (ø)`
Sources/Request/Request/Request.swift	`93.26% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 678327f...5af244c. Read the comment docs.

carson-katri commented 4 years ago

LGTM 👍

carson-katri / swift-request

RequestError is now a type of Error #31

Codecov Report