search

carson-katri / swift-request

Declarative HTTP networking, designed for SwiftUI
MIT License
727 stars 41 forks source link

Simplify RequestParam internal API #42

Closed o-nnerb closed 3 years ago

o-nnerb commented 3 years ago
carson-katri commented 3 years ago

I'm personally not a fan of putting the license in every file... Would you mind reverting that?

o-nnerb commented 3 years ago

Alright, no problem

codecov-io commented 3 years ago

Codecov Report

Merging #42 (b0a5061) into master (89e948d) will decrease coverage by 0.09%. The diff coverage is 93.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   81.25%   81.15%   -0.10%     
==========================================
  Files          23       28       +5     
  Lines         480      467      -13     
==========================================
- Hits          390      379      -11     
+ Misses         90       88       -2
Impacted Files Coverage Δ
...urces/Request/Request/RequestParams/AnyParam.swift 0.00% <0.00%> (ø)
Sources/Request/Request/RequestBuilder.swift 66.66% <57.14%> (-12.29%) :arrow_down:
...ces/Request/Request/RequestParams/QueryParam.swift 92.30% <90.00%> (-7.70%) :arrow_down:
Sources/Request/Request/RequestParams/Query.swift 92.30% <92.30%> (ø)
Sources/Request/Request/Extra/RequestChain.swift 100.00% <100.00%> (ø)
Sources/Request/Request/Request.swift 100.00% <100.00%> (+6.81%) :arrow_up:
Sources/Request/Request/RequestParams/Body.swift 100.00% <100.00%> (ø)
...Request/Request/RequestParams/CombinedParams.swift 100.00% <100.00%> (ø)
...ces/Request/Request/RequestParams/EmptyParam.swift 100.00% <100.00%> (ø)
Sources/Request/Request/RequestParams/Header.swift 100.00% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 89e948d...b0a5061. Read the comment docs.

carson-katri commented 3 years ago

This looks good to me, was there anything else you needed to add/change for this PR? If not, I'll merge it now.

o-nnerb commented 3 years ago

@carson-katri you can merge it