search

carson-katri / swift-request

Declarative HTTP networking, designed for SwiftUI
MIT License
727 stars 41 forks source link

Support MultipartFormData #43

Closed o-nnerb closed 3 years ago

o-nnerb commented 3 years ago

Added the FormParam, Form.Data, Form.File and FormBuilder.

Depends #42

codecov-io commented 3 years ago

Codecov Report

Merging #43 (4951537) into master (89e948d) will decrease coverage by 1.82%. The diff coverage is 84.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   81.25%   79.42%   -1.83%     
==========================================
  Files          23       35      +12     
  Lines         480      554      +74     
==========================================
+ Hits          390      440      +50     
- Misses         90      114      +24
Impacted Files Coverage Δ
Sources/Request/Request/FormParam/Form.File.swift 0.00% <0.00%> (ø)
.../Request/Request/FormParam/FormBuilder.Empty.swift 0.00% <0.00%> (ø)
...urces/Request/Request/RequestParams/AnyParam.swift 0.00% <0.00%> (ø)
...s/Request/Request/RequestParams/SessionParam.swift 0.00% <0.00%> (ø)
...ces/Request/Request/RequestParams/EmptyParam.swift 50.00% <50.00%> (ø)
Sources/Request/Request/RequestBuilder.swift 66.66% <57.14%> (-12.29%) :arrow_down:
Sources/Request/Request/FormParam/Form.Data.swift 69.23% <69.23%> (ø)
...ces/Request/Request/RequestParams/QueryParam.swift 92.30% <90.00%> (-7.70%) :arrow_down:
Sources/Request/Request/RequestParams/Query.swift 92.30% <92.30%> (ø)
Sources/Request/Request/Extra/RequestChain.swift 100.00% <100.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 02d010c...3b42ba7. Read the comment docs.

o-nnerb commented 3 years ago

@carson-katri can you review this?

carson-katri commented 3 years ago

Overall looks great, amazing work. I had a few nitpicks and ideas on improving the API a bit

o-nnerb commented 3 years ago

Overall looks great, amazing work. I had a few nitpicks and ideas on improving the API a bit

@carson-katri feel free to improve this implementation, I guess swift-request will help and inspire other developers. Thanks, we did nice work!

carson-katri commented 3 years ago

If you'd rather I fix this separately, lmk.

o-nnerb commented 3 years ago

You can do it. I'm really busy for this next days

o-nnerb commented 3 years ago

@carson-katri plz review it

carson-katri commented 3 years ago

Sorry I wasn’t able to get on this sooner! Been really busy. Thank you for the addition, I’ll release a new version soon 👍