search

carson-katri / swift-request

Declarative HTTP networking, designed for SwiftUI
MIT License
727 stars 41 forks source link

RequestImage remove animation #48

Closed ca13ra1 closed 3 years ago

ca13ra1 commented 3 years ago

Setting nil doesn't seem to remove animation from RequestImage, testing on iOS 14.

RequestImage(Url("url_here"))
   .animation(nil)
carson-katri commented 3 years ago

You should be able to pass the desired animation directly into RequestImage:

RequestImage(url, animation: nil)

ca13ra1 commented 3 years ago

I'm getting 'nil' is not compatible with expected argument type 'Animation'

carson-katri commented 3 years ago

I just made Animation optional in the swiftui branch, so that should now be valid.

ca13ra1 commented 3 years ago

Thank you again! 😊

carson-katri commented 3 years ago

No problem, thanks for catching these bugs

ca13ra1 commented 3 years ago

Anytime!