Open jGaboardi opened 6 months ago
I mean, yeh awesome. That would be amazing!
py312_latest
bare-bones environment + GHA for testing current package / code base - ensure passing – #23
.github/workflows/testing.yml
ci/py312_latest.yml
- Ubuntu.travis.yml
– #25 pyproject.toml
– #30
setup.py
requirements.txt
recommended.txt
.coveragerc
setuptools-scm
for versioningcodecov.yml
and turn on for the repo
ruff
specifications to pyproject.toml
for linting and formatting codebase – #31
ruff
specificationsruff
specifications.pre-commit-configuration.yaml
+ turn on pre-commit for repo – #32 pyproject.toml
py310_oldest
(based on SPEC000)py311_latest
py312_dev
notebooks/
or examples/
directory with some demonstrations
scipy.spatial.distance
functionsREADME
for updates, badges, etc. :
README
docs/
+ a GHPages site built from a GHAv*
tags (automated publishing on PyPI)conda-forge
as a feedstock
alpha
, etc release sand iterate until all actions, etc are in orderfastpair
🥳 🎉 @carsonfarmer This is a loosely sequential checklist of proposed activities. Some make sense to do in individual PRs and some may be grouped. Let me know if you have any questions or concerns with anything here, otherwise I'll see about getting started with (1.)
TL;DR: This all looks good to me!
I'm pretty unfamiliar with modern Python development flows at this stage @jGaboardi, so I would defer to your judgement here. Since I have, in fact, met you in person, I have done ahead and invited you to be a collaborator on this repo. You should have direct access to GitHub Actions etc as needed with that invite?
Totally separate note: Is PySAL using this library?
Totally separate note: Is PySAL using this library?
Not currently, but I became aware of fastpair
last summer when @ljwolf, @gegen07, and I were working with a student in a PySAL GSoC project for spopt
. So there's potential for inclusion later down the line in our new KNearestPMedian
model, but we'll need to do performance testing, benchmarking, etc. before that happens. So, my contributions here are for 3 reasons (in order of general to specific):
pysal/spopt
reason mentioned above.@jGaboardi I saw a lot of work done by you! Awesome! Any help wanted? The spopt will be helped with this brilliant implementation, thanks @carsonfarmer!
@carsonfarmer For context here, @gegen07 was an outstanding PySAL GSoC 2021 student several years back that brought the locate
module into existence, and he has since joined us on the core team.
Any help wanted?
Of course! Your insight is always valuable, specifically due to your CS background. Anything specific that has caught your eye in the issues?
I can't speak for @carsonfarmer but IMHO we should get fastpair
modernized with an actual release before addressing enhancements like:
No problem with current issues. All good! I'll take a look at the issues for in-depth enhancements. Agree with you, before enhancing it, let's get it over the release cycle first.
@carsonfarmer Do you have any interest in seeing
fastpairs
modernized (e.g., Python 312 compatibility,pyproject.toml
, GHA for testing, structured formatting & linting, etc.)? If so (and as time permits), I can start making specific tickets and chipping away at it.xref: #12