carsonfarmer / fastpair

FastPair: Data-structure for the dynamic closest-pair problem.
MIT License
12 stars 4 forks source link

kicking off #20 - modernizing `fastpairs` #24

Closed jGaboardi closed 1 month ago

jGaboardi commented 1 month ago

This PR kick of #20:

[!IMPORTANT] @carsonfarmer Perhaps before merging this PR:

  • We should tag the current main with fastpair==0.1.0 to give a good point-in-time break
  • Then I can update this PR and add back in a simple version=0.1.0 into the setup.py
  • Once pyproejct.toml & setuptools-scm are adopted as described in #20, versioning will be automated by manual tagging.
carsonfarmer commented 1 month ago

Ok, I kicked off a tag (https://github.com/carsonfarmer/fastpair/tags) (and release) based on fastpair==0.1.0 (I'm not used to that x==y convention, so hopefully I did that right?).

jGaboardi commented 1 month ago

fastpair==0.1.0 (I'm not used to that x==y convention

LOL whoops. That was simply my shorthand for meaning version 0.1.0; I should have been more clear.

I'll update the tag and release as v0.1.0. We'll start using the vX.Y.Z convention, as it is useful in pushing tags that kick off automated actions. See example here.

carsonfarmer commented 1 month ago

I generally follow the convention of, if you get a 👍 then you can merge your own PRs. Is this a good convention for you too?

jGaboardi commented 1 month ago

I generally follow the convention of, if you get a 👍 then you can merge your own PRs. Is this a good convention for you too?

I can get on board with that.