search

carsonfarmer / fastpair

FastPair: Data-structure for the dynamic closest-pair problem.
MIT License
12 stars 4 forks source link

[INFRA] tag `fastpair==0.1.0` causing on issue on install #29

Closed jGaboardi closed 1 month ago

jGaboardi commented 1 month ago

While working on (3.) in https://github.com/carsonfarmer/fastpair/issues/20, I am running into the problem of there being no associated dynamic version with the fastpair==0.1.0 tag, which is causing the pip install -e . to fail.

The two options (IMHO) are a conservative approach [1,2] or a more aggressive approach [2] that does it all at once.

  1. conservative approach (2 PRs):
    1. explicitly declaring version = "v0.1.0" in pyproject.toml in a first PR addressing (3.)
    2. (perhaps create a v0.1.1 tag and associated release, but this might be overkill)
    3. proceed to step 2
  2. one stroke (1 PR):
    1. delete the fastpair==0.1.0 tag (remote & local)
    2. declare dynamic = ["version"] in pyproject.toml

@carsonfarmer Let me know if (A) you have any questions/concerns here; and (B) which approach you'd like me to take.

carsonfarmer commented 1 month ago

Since we didn't have tags and releases before, I don't see any reason not to just go with option 2. But I'm happy to adopt either, I leave it up to you.

jGaboardi commented 1 month ago

I'll go with option 2.