carsonfarmer / fastpair

FastPair: Data-structure for the dynamic closest-pair problem.
MIT License
12 stars 4 forks source link

consolidate infrastructure into `pyproject.tml` #30

Closed jGaboardi closed 1 month ago

jGaboardi commented 1 month ago

This PR:

@carsonfarmer I am not trying to pull a quick one on you or move faster than you are comfortable. Please do not hesitate to raise any questions/concerns if these changes are overwhelming (or you simply need clarification).

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.0%. Comparing base (4ec960e) to head (8a3840d).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/carsonfarmer/fastpair/pull/30/graphs/tree.svg?width=650&height=150&src=pr&token=9VQNETZHJX&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Carson+Farmer)](https://app.codecov.io/gh/carsonfarmer/fastpair/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Carson+Farmer) ```diff @@ Coverage Diff @@ ## main #30 +/- ## ======================================== Coverage 100.0% 100.0% ======================================== Files 3 2 -1 Lines 328 127 -201 ======================================== - Hits 328 127 -201 ``` | [Files](https://app.codecov.io/gh/carsonfarmer/fastpair/pull/30?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Carson+Farmer) | Coverage Δ | | |---|---|---| | [fastpair/\_\_init\_\_.py](https://app.codecov.io/gh/carsonfarmer/fastpair/pull/30?src=pr&el=tree&filepath=fastpair%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Carson+Farmer#diff-ZmFzdHBhaXIvX19pbml0X18ucHk=) | `100.0% <100.0%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/carsonfarmer/fastpair/pull/30/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Carson+Farmer)
jGaboardi commented 1 month ago

I've checked a buncha this stuff locally. And looked up all the packages. It looks pretty straight-forward. Left a few questions of clarification for you.

Sounds good. I've left some justifications and will wait for your re-review.